-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added colormaps, figure size control and facets to support subquestio… #52
Conversation
Hi @nikhil153, thanks a lot for your work on this. To make reviewing this easier, would you mind incorporating your changes into the I think in your last PR I refactored this script a little bit, but you can replace the script contents directly with the contents of your Jupyter notebook if that's easier, and I can help refactor again as needed. Also, for this:
I think our best bet might be to just plot a vertical line at that the right x value, separate from the bars themselves. Can help w/ trying to implement this if needed |
@alyssadai - updated the python script! |
- asserts commented out to reduce logic
New changes added:
Re lines between bars: after investigating a bit, this should be doable via a custom go.layout.Shape, but would require quite a bit of additional logic as the line height must be manually adjusted and change depending on height of the bar, and whether party stratify is turned on. Not implementing for now, as recommended by Nikhil. |
This is going to be tricky with plotly express. So currently just showing the labels inside the bar.
Changing single border doesn't seem to be easy either... currently added an option to control all the line widths of the bar plot.