-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Update map graphic #51
[ENH] Update map graphic #51
Conversation
Hey @michellewang, thanks a lot for the PR. Some notes on aesthetics based on our chat today:
|
Also, just had another thought related to your q about the state labels on the map. One thing you could try if you like is making the text bold, to make it stand out a bit more. Up to you though! |
Before I forget, here is a custom yellow-red cmap we can use as a default for the opinion data. These are colors from Nikhil's colormap used in the bar charts, with an extra light yellow color (kind of arbitrarily selected) I added for the lower limit:
|
@alyssadai with updated colourmaps, bold state labels and different colour for clicked state outline: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @michellewang, this looks awesome - sorry my review took a while.
Left mostly docstring update suggestions so we easily can find what args/defaults to change if needed.
One non-essential suggestion if you have time (no worries if not): could we change the number of decimals for percentages in the map from 2 to 1, to match the descriptive plots and bar plots?
Feel free to merge when ready 🎉
vmin = df_to_plot[col_gradient].min() | ||
vmax = df_to_plot[col_gradient].max() | ||
vmin = max(0, df_to_plot[col_gradient].min() - colormap_range_padding) | ||
vmax = min(100, df_to_plot[col_gradient].max() + colormap_range_padding) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
neato!!
Thanks @alyssadai for the review :) I made the percentages in the hoverboxes have 1 decimal point and added |
Closes #26.
Summary:
"Greens"
for opinions and"Oranges"
for impactsScreenshot for opinion:
Screenshot for weather impact: