Implemented sample description drawer #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nce/us_climate_emotions_map into adai/setup-app-nav
alyssadai
approved these changes
May 24, 2024
There was a problem hiding this comment.
Thanks @rmanaem for the PR, this looks and works great 🎉
For the sake of merging this quickly, I pushed a 🍒 change to remove an unneeded else statement (and de-indent your return statement inside) in the two callbacks I highlighted below. Hope you don't mind!
🧑🍳 , will merge this directly!
climate_emotions_map/app.py
Outdated
| """Callback function for updating the state in the drawer.""" | ||
| if value is None: | ||
| return "National" | ||
| else: |
There was a problem hiding this comment.
I don't think you need the else here, since the previous if returns you out of the function!
climate_emotions_map/app.py
Outdated
| df = SURVEY_DATA["samplesizes_state.tsv"] | ||
| if value is None: | ||
| return f"Sample size: {NATIONAL_SAMPLE_SIZE}" | ||
| else: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13
Changes proposed in this pull request:
create_sample_description_drawerfunction to render a drawer element in the UIcreate_drawer_statefunction for creating and updating state/cluster in the drawercreate_drawer_sample_sizefunction for creating and updating sample size in the drawer