Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Detect submodule changes using git status instead of git pull #103

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

alyssadai
Copy link
Collaborator

Using the output of git pull run on the submodule main branch to signal if there are any new changes in the submodule doesn't really work because even as the submodule has updated to point to the latest commit, git pull will still show as Already up to date. It's only when we check the status of the parent repo (..) that we'll see changes in the data directory.

Current behaviour: even though the wf correctly detects uncommitted changes in the working directory after the Update submodule step (because it is looking for changes in the directory root) + then correctly opens a PR to update the submodule pointer, during the step, the script to regenerate figures is not triggered.

To resolve this, we use the output of git status in the root as the indicator of submodule changes instead.

@alyssadai alyssadai merged commit e0c5437 into main Oct 28, 2024
1 check passed
@alyssadai alyssadai deleted the fix-update-submodule-wf branch October 28, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant