[CI] Detect submodule changes using git status
instead of git pull
#103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the output of
git pull
run on the submodulemain
branch to signal if there are any new changes in the submodule doesn't really work because even as the submodule has updated to point to the latest commit,git pull
will still show asAlready up to date
. It's only when we check the status of the parent repo (..
) that we'll see changes in thedata
directory.Current behaviour: even though the wf correctly detects uncommitted changes in the working directory after the
Update submodule
step (because it is looking for changes in the directory root) + then correctly opens a PR to update the submodule pointer, during the step, the script to regenerate figures is not triggered.To resolve this, we use the output of
git status
in the root as the indicator of submodule changes instead.