Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tabular tracker and fix doughnut variable names #76

Merged
merged 5 commits into from
Feb 13, 2024

Conversation

michellewang
Copy link
Collaborator

@michellewang michellewang commented Nov 17, 2023

Closes #75.

Also formats the tabular bagel to the format accepted by the dashboard.

Copy link
Collaborator

@nikhil153 nikhil153 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a bit more documentation on the logic flow.
All good otherwise!


def loading_func(df):
if COL_UPDRS3 in df.columns:
print(f'Filtering {COL_UPDRS3}')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not urgent, but switch to logger?

nipoppy/workflow/tabular/tabular_tracker.py Show resolved Hide resolved
# find subjects with multiple age entries for the same visit
groups = df.groupby([COL_SUBJECT_TABULAR, COL_VISIT_TABULAR])[COL_AGE]
counts = groups.count()
records_with_multiple_ages = counts[counts > 1].index.unique()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add what we mean by record in the docs.

nipoppy/workflow/tabular/tabular_tracker.py Outdated Show resolved Hide resolved
@michellewang michellewang merged commit 60d981d into main Feb 13, 2024
4 checks passed
@michellewang michellewang deleted the 75/tabular_tracker branch February 13, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update tabular tracker
2 participants