Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to match neurodatascience/nipoppy:main #100

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Conversation

michellewang
Copy link
Collaborator

PR created/updated automatically by create-pull-request GitHub action. Will be merged automatically by automerge-action if there are no merge conflicts.

…oppy#263)

* update manifest/doughnut columns (and DicomDirMap partially)

* rename column `session` -> `session_id` in DicomDirMap

* remove dicom_id and bids_id fields from doughnut

* change sourcedata expected subdirectory names

* rename check_session -> session_id_to_bids_id and participant_id_to_bids_id -> participant_id_to_bids_participant

* refactor participant/session ID checking functions

* rename bids_id -> bids_participant and session -> bids_session in invocations

* update CLI arguments for participant/session

* rename variables participant -> participant_id and session -> session_id

* make test_default_config tests fail if replacement didn't work

* rename column attributes in tabular classes (except Bagel)

* rename VISIT/SESSION fields in global config

* rename doughnut status columns

* update raw dicom/imaging data directory to scratch/raw_imaging

* add test for session_id_to_bids_session

* address code review comments
Copy link
Collaborator

@bcmcpher bcmcpher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR approved by auto-approve-action GitHub action.

@michellewang michellewang merged commit e0012f4 into main Jun 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants