[REF] Enable handling of partial node response success

[surchs]

• Closes Handle partial node query successes when all nodes are selected #60

Changes proposed in this pull request:

• Refactored mocked API responses into
  • query response section
  • attribute response section
• reused most of the responses to make the mocks less cluttered / easier to understand
• added an e2e test for the "happy path" of the app to assert that no warnings are shown
  • closes Create an e2e test to ensure the app loads correctly #96
• expanded the API request tests to cover the new partial and complete success and failure cases for attribute requests
• updated the types in the ResultsContainer

Checklist

This section is for the PR reviewer

• PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
• PR has a label for the release changelog or skip-release (to be applied by maintainers only)
• PR links to GitHub issue with mention Closes #XXXX
• Tests pass
• Checks pass

For new features:

• Tests have been added

For bug fixes:

• There is at least one test that would fail under the original bug conditions.

[netlify]

✅ Deploy Preview for neurobagel-query ready!

Name	Link
🔨 Latest commit	613365c
🔍 Latest deploy log	https://app.netlify.com/sites/neurobagel-query/deploys/6615af50a0734b0008411d0d
😎 Deploy Preview	https://deploy-preview-97--neurobagel-query.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[rmanaem]

Thanks for taking over this @surchs!
The refactor looks clean and nicely done.
🍒 One thing I noticed is missing is handling failure case for attributes and query response.

[rmanaem]

added an e2e test for the "happy path" of the app to assert that no warnings are shown

Is this referring to this test?

query-tool/cypress/e2e/APIRequests.cy.ts

Lines 14 to 42 in 3994a0b

	describe('Successful API attribute responses', () => {
	beforeEach(() => {
	cy.intercept(
	{
	method: 'GET',
	url: '/nodes/',
	},
	nodeOptions
	).as('getNodes');
	cy.intercept(
	{
	method: 'GET',
	url: '/attributes/nb:Diagnosis',
	},
	diagnosisOptions
	).as('getDiagnosisOptions');
	cy.intercept(
	{
	method: 'GET',
	url: '/attributes/nb:Assessment',
	},
	assessmentToolOptions
	).as('getAssessmentToolOptions');
	cy.visit('/');
	cy.wait(['@getNodes', '@getDiagnosisOptions', '@getAssessmentToolOptions']);
	});
	it('Loads correctly if all node responses are successful', () => {
	cy.get('.notistack-SnackbarContainer').should('not.exist');
	});

[surchs]

added an e2e test for the "happy path" of the app to assert that no warnings are shown

Is this referring to this test?

query-tool/cypress/e2e/APIRequests.cy.ts

Lines 14 to 42 in 3994a0b

	describe('Successful API attribute responses', () => {
	beforeEach(() => {
	cy.intercept(
	{
	method: 'GET',
	url: '/nodes/',
	},
	nodeOptions
	).as('getNodes');
	cy.intercept(
	{
	method: 'GET',
	url: '/attributes/nb:Diagnosis',
	},
	diagnosisOptions
	).as('getDiagnosisOptions');
	cy.intercept(
	{
	method: 'GET',
	url: '/attributes/nb:Assessment',
	},
	assessmentToolOptions
	).as('getAssessmentToolOptions');
	cy.visit('/');
	cy.wait(['@getNodes', '@getDiagnosisOptions', '@getAssessmentToolOptions']);
	});
	it('Loads correctly if all node responses are successful', () => {
	cy.get('.notistack-SnackbarContainer').should('not.exist');
	});

Yes, exactly!

[rmanaem]

🍒

[rmanaem]

🧑‍🍳

[surchs]

🚀 PR was released in v0.2.0 🚀