Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fixed parsing of NB_IS_FEDERATION_API #88

Merged
merged 4 commits into from
Mar 18, 2024
Merged

[FIX] Fixed parsing of NB_IS_FEDERATION_API #88

merged 4 commits into from
Mar 18, 2024

Conversation

rmanaem
Copy link
Contributor

@rmanaem rmanaem commented Mar 13, 2024

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@rmanaem rmanaem added the pr-bug-fix Bug fix, will increment patch version when merged (0.0.+1) label Mar 13, 2024
Copy link

netlify bot commented Mar 13, 2024

Deploy Preview for neurobagel-query ready!

Name Link
🔨 Latest commit 45030d7
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-query/deploys/65f88ad4ebff04000896a9cd
😎 Deploy Preview https://deploy-preview-88--neurobagel-query.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@surchs surchs self-requested a review March 17, 2024 21:37
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @rmanaem but this seems to change default behaviour. Could you please confirm and add tests

src/components/QueryForm.tsx Show resolved Hide resolved
src/utils/constants.ts Outdated Show resolved Hide resolved
@rmanaem rmanaem requested a review from surchs March 18, 2024 18:20
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧑‍🍳

@surchs
Copy link
Contributor

surchs commented Mar 18, 2024

before you merge @rmanaem, mind updating the commit message in the squashed commit:

Modified the fix so the default is false

to instead say true - I blieve that's what you meant?

@rmanaem
Copy link
Contributor Author

rmanaem commented Mar 18, 2024

to instead say true - I blieve that's what you meant?

Yes, good catch.

@rmanaem rmanaem merged commit 4ac0bf0 into main Mar 18, 2024
9 checks passed
@rmanaem rmanaem deleted the bug-84 branch March 18, 2024 18:49
@surchs
Copy link
Contributor

surchs commented Apr 11, 2024

🚀 PR was released in v0.2.0 🚀

@surchs surchs added the released This issue/pull request has been released. label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bug-fix Bug fix, will increment patch version when merged (0.0.+1) released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NB_IS_FEDERATION_API is not parsed correctly
2 participants