Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] Dockerized the app #51

Merged
merged 7 commits into from
Mar 6, 2024
Merged

[MNT] Dockerized the app #51

merged 7 commits into from
Mar 6, 2024

Conversation

rmanaem
Copy link
Contributor

@rmanaem rmanaem commented Mar 5, 2024

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@rmanaem rmanaem added the pr-internal Non-user-facing code improvement, will increment patch version when merged (0.0.+1) label Mar 5, 2024
Copy link

netlify bot commented Mar 5, 2024

Deploy Preview for neurobagel-query ready!

Name Link
🔨 Latest commit 6ca31a3
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-query/deploys/65e8cd734a25ba0008057b3e
😎 Deploy Preview https://deploy-preview-51--neurobagel-query.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@surchs surchs self-requested a review March 5, 2024 22:59
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @rmanaem, looks good.

Mind taking a look at the questions I posted - and then should be 🧑‍🍳

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Copy link

netlify bot commented Mar 6, 2024

Deploy Preview for neurobagel-query-tool ready!

Name Link
🔨 Latest commit 6ca31a3
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-query-tool/deploys/65e8cd72f189ad00083b9a24
😎 Deploy Preview https://deploy-preview-51--neurobagel-query-tool.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rmanaem
Copy link
Contributor Author

rmanaem commented Mar 6, 2024

❌ Deploy Preview for neurobagel-query-tool failed.

Name Link
🔨 Latest commit 35d712e
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-query-tool/deploys/65e8c2851a71110008c3f119

@surchs I reckon we need to update the netlify build script.

@surchs
Copy link
Contributor

surchs commented Mar 6, 2024

Should build now: https://deploy-preview-51--neurobagel-query-tool.netlify.app/?node=All

@rmanaem rmanaem requested a review from surchs March 6, 2024 20:12
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🧑‍🍳

@rmanaem rmanaem merged commit 6d61865 into main Mar 6, 2024
12 checks passed
@rmanaem rmanaem deleted the maint-48 branch March 6, 2024 21:06
@surchs
Copy link
Contributor

surchs commented Mar 7, 2024

🚀 PR was released in v0.1.0 🚀

@surchs surchs added the released This issue/pull request has been released. label Mar 7, 2024
@rmanaem rmanaem mentioned this pull request Mar 12, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-internal Non-user-facing code improvement, will increment patch version when merged (0.0.+1) released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dockerize the app
2 participants