Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Set up ESLint CI #47

Merged
merged 3 commits into from
Mar 4, 2024
Merged

[CI] Set up ESLint CI #47

merged 3 commits into from
Mar 4, 2024

Conversation

rmanaem
Copy link
Contributor

@rmanaem rmanaem commented Mar 4, 2024 •
edited by surchs
Loading

Checklist

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@rmanaem rmanaem added the pr-internal Non-user-facing code improvement, will increment patch version when merged (0.0.+1) label Mar 4, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 4, 2024 •
edited
Loading

✅ Deploy Preview for neurobagel-query ready!

Name Link
🔨 Latest commit 4db1e00
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-query/deploys/65e618eaab2a710008bbe697
😎 Deploy Preview https://deploy-preview-47--neurobagel-query.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@surchs surchs self-requested a review March 4, 2024 18:19
surchs
surchs approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 thanks @rmanaem! one suggestion for npm ci - otherwise looks great

🧑‍🍳

.github/workflows/lint.yaml Outdated Show resolved Hide resolved
src/components/ResultCard.tsx Outdated Show resolved Hide resolved
@rmanaem
Updated lint workflow config file
4db1e00 
to use `npm ci` instead of `npm install` for installing
dependencies.
@rmanaem rmanaem merged commit a3573d4 into main Mar 4, 2024
8 checks passed
@rmanaem rmanaem deleted the maint-46 branch March 4, 2024 18:58
@surchs
Copy link
Contributor

surchs commented Mar 7, 2024

🚀 PR was released in v0.1.0 🚀

@surchs surchs added the released This issue/pull request has been released. label Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surchs surchs surchs approved these changes

Assignees
No one assigned
Labels
pr-internal Non-user-facing code improvement, will increment patch version when merged (0.0.+1) released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ESLint CI
2 participants
@rmanaem @surchs