This repository has been archived by the owner on Mar 9, 2024. It is now read-only.
[ENH] Implemented separate download buttons for participant and dataset #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented two buttons - One for downloading participant-level results tsv - One for downloading dataset-level results tsv - Removed the toggle checkbox - Removed `toggleResultsTSV` data property - Updated `generateTSVString` and `downloadResults` methods - Reworked component template
✅ Deploy Preview for neurobagel-query-tool ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
surchs
approved these changes
Jul 12, 2023
There was a problem hiding this comment.
Hey @rmanaem, thanks for the PR. I left some comments for you to look at and apply as you see fit. I would change the PR title to [ENH] Separate download buttons for dataset and participant to help us later find this change in the log.
With those, good to go 🧑🍳 !
rmanaem
changed the title
button -> buttons
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #141
Changes proposed in this pull request:
toggleResultsTSVdata propertygenerateTSVStringanddownloadResultsmethodsChecklist
[ENH],[BUG],[DOC],[INFRA],[MAINT])Closes #XXXXFor new features:
For bug fixes: