Skip to content
This repository has been archived by the owner on Mar 9, 2024. It is now read-only.

Make two buttons for dataset- and participant-level results #141

Closed
5 tasks done
Tracked by #70
surchs opened this issue Jul 10, 2023 · 2 comments · Fixed by #145
Closed
5 tasks done
Tracked by #70

Make two buttons for dataset- and participant-level results #141

surchs opened this issue Jul 10, 2023 · 2 comments · Fixed by #145
Assignees
Labels
feat:improve Incremental, user facing improvements of an existing feature. feedback:user feedback Feedback from our users. Either direct issue submission or conveyed feedback type:feature Effort to deliver new features, feature changes & improvements

Comments

@surchs
Copy link
Contributor

surchs commented Jul 10, 2023

Originally posted by @michellewang in neurobagel/query-tool#93 (comment):

I didn’t realize until someone pointed it out yesterday that we could toggle between dataset-level and participant-level results. Personally, I think it would be better to have 2 download buttons instead of the “Toggle level of detail to download” checkbox

To resolve:

  • have one permanently visible button "Download dataset results". Clicking it will download the dataset-level.csv
  • have one permanently visible button "Download participant results". Clicking it will download the participant-level.csv
  • Both buttons should become enabled and disabled in the same way the current download button does (e.g. disabled unless at least one dataset is selected)
  • If button text is too large, we can have a linebreak in there (i.e. make button bigger)
  • Update README.md
  • Update related tests
@surchs surchs moved this to Backlog in Neurobagel Jul 10, 2023
@surchs surchs added feat:improve Incremental, user facing improvements of an existing feature. feedback:user feedback Feedback from our users. Either direct issue submission or conveyed feedback type:feature Effort to deliver new features, feature changes & improvements labels Jul 10, 2023
@rmanaem rmanaem moved this from Backlog to Implement - Active in Neurobagel Jul 11, 2023
@rmanaem rmanaem self-assigned this Jul 11, 2023
@rmanaem
Copy link
Collaborator

rmanaem commented Jul 11, 2023

@surchs @jarmoza Do you have any thoughts on the placement of the buttons in the UI, one stacked on top of the other or next to each other?

@jarmoza
Copy link
Contributor

jarmoza commented Jul 11, 2023

I think side by side.

@rmanaem rmanaem moved this from Implement - Active to Implement - Done in Neurobagel Jul 12, 2023
@surchs surchs moved this from Implement - Done to Review - Active in Neurobagel Jul 12, 2023
@github-project-automation github-project-automation bot moved this from Review - Active to Review - Done in Neurobagel Jul 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feat:improve Incremental, user facing improvements of an existing feature. feedback:user feedback Feedback from our users. Either direct issue submission or conveyed feedback type:feature Effort to deliver new features, feature changes & improvements
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants