-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Implemented custom filtering function #831
Conversation
Reviewer's Guide by SourceryThis PR implements a custom filtering function for dropdown selections and removes the integer value transformation option. The filtering function provides a more intuitive search experience by matching characters in sequence rather than requiring exact substring matches. The changes are implemented across multiple Vue components and include updates to the store and test files. ER diagram for removed integer value transformation optionerDiagram
STORE {
string bounded
string euro
string float
string iso8601
}
STORE ||--o{ TRANSFORM_OPTIONS : contains
TRANSFORM_OPTIONS {
string TermURL
string Label
}
note for STORE "Removed 'int' transformation option"
Class diagram for updated Vue components with custom filteringclassDiagram
class CategoryToolgroup {
+filterOptions(option, label, search)
+selectTool(selectedTool)
}
class AnnotCategorical {
+filterOptions(option, label, search)
+selectOptionAndUpdate(p_optionValue, p_columnName, p_rawValue)
}
CategoryToolgroup --> AnnotCategorical : uses
note for CategoryToolgroup "Added custom filtering function"
note for AnnotCategorical "Added custom filtering function"
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
✅ Deploy Preview for neurobagel-annotator ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @rmanaem - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider extracting the duplicate filterOptions function into a shared utility function or mixin to avoid code duplication between category-toolgroup.vue and annot-categorical.vue
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️ 🧑🍳 ✔️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧑🍳
Checklist
This section is for the PR reviewer
[ENH]
,[FIX]
,[REF]
,[TST]
,[CI]
,[MNT]
,[INF]
,[MODEL]
,[DOC]
) (see our Contributing Guidelines for more info)Closes #XXXX
For new features:
For bug fixes:
Summary by Sourcery
Implement a custom filtering function for v-select components to improve search functionality and enhance user interface text for clarity.
New Features:
Enhancements: