Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Added Subject ID/Participant ID to JSON output file #584

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Conversation

rmanaem
Copy link
Contributor

@rmanaem rmanaem commented Oct 25, 2023

Closes #477

Changes proposed in this pull request:

  • Updated alterColumnCategoryMapping mutation to add the column mapped to Subject ID to the annotated data dictionary in the state
  • Update getJSONOutput getter to add participant_id to the output file
  • Expanded download-pagetests to check for identifies property and its value under participant_id key of the output file

Checklist

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@netlify
Copy link

netlify bot commented Oct 25, 2023

Deploy Preview for neurobagel-annotator ready!

Name Link
🔨 Latest commit 8b739c9
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-annotator/deploys/65397185e205ae000825beeb
😎 Deploy Preview https://deploy-preview-584--neurobagel-annotator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rmanaem rmanaem marked this pull request as ready for review October 25, 2023 20:18
@surchs surchs self-requested a review October 25, 2023 20:54
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think that does it, @rmanaem!

🧑‍🍳

@rmanaem rmanaem merged commit 9ce6126 into master Oct 25, 2023
7 checks passed
@rmanaem rmanaem deleted the feat-477 branch October 25, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] Adding 'Subject ID'/'Participant ID' to 'Annotations' section of data dictionary
2 participants