Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] Implemented getColumnsForCategory and getUniqueColumnValues #569

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

rmanaem
Copy link
Contributor

@rmanaem rmanaem commented Oct 12, 2023

Closes #568

Changes proposed in this pull request:

  • Added Assessment Tool to the categories object in store state
  • Implemented getColumnsForCategory and getUniqueColumnValues
  • Refactored getUniqueValues and moved some of its logic to the newly implemented getters

Checklist

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

Refactored `getUniqueValues` and moved some of its logic to the
newly implemented getters
@rmanaem rmanaem requested a review from surchs October 12, 2023 16:12
@netlify
Copy link

netlify bot commented Oct 12, 2023

Deploy Preview for neurobagel-annotator ready!

Name Link
🔨 Latest commit b53198b
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-annotator/deploys/652845fc3e6bbd00085b2b46
😎 Deploy Preview https://deploy-preview-569--neurobagel-annotator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧑‍🍳

@rmanaem rmanaem merged commit b7050b4 into master Oct 12, 2023
7 checks passed
@rmanaem rmanaem deleted the maint-568 branch October 12, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make new getters for columns assigned to category
2 participants