Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] Capitalized age heuristics #562

Merged
merged 2 commits into from
Oct 4, 2023
Merged

[MNT] Capitalized age heuristics #562

merged 2 commits into from
Oct 4, 2023

Conversation

rmanaem
Copy link
Contributor

@rmanaem rmanaem commented Oct 3, 2023

Closes #561

Checklist

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@netlify
Copy link

netlify bot commented Oct 3, 2023

Deploy Preview for neurobagel-annotator ready!

Name Link
🔨 Latest commit f429d9f
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-annotator/deploys/651c52b5f257690008499774
😎 Deploy Preview https://deploy-preview-562--neurobagel-annotator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@surchs surchs self-requested a review October 4, 2023 14:21
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test changes look good! 🧑‍🍳

Sidecomment: not sure the specific controlled term / the stuff you just changed has any effect in the tests. i.e. the fact that you made the tests align with the hardcoded values in the store is very important, but nothing would break if you had forgotten that, right? My point is: it would be nice if we could make it so something does break if we forget - so that we don't forget.

@rmanaem rmanaem merged commit 485ca1f into master Oct 4, 2023
@rmanaem rmanaem deleted the maint-561 branch October 4, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Capitalize age heuristics
2 participants