Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prompt user - unsaved changes & nav away #46

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xgui3783
Copy link

  • Run npm test successfully.

  • Run npm run mochasuccessfully.

  • test_screenshots generates the same test pictures in test as there were in test/reference and does not show any errors

(I don't think new screenshots are generated properly?)

@xgui3783 xgui3783 marked this pull request as draft October 16, 2021 11:04
@xgui3783 xgui3783 changed the title feat: prompt user - unsaved changes && nav away feat: prompt user - unsaved changes & nav away Oct 16, 2021
@xgui3783
Copy link
Author

Unfortunately, I can't seem to test this functionality properly. The bundled images seems to have Hash to be undefined.

I will have to take a better look when I get a chance.

@katjaq
Copy link
Member

katjaq commented Jan 19, 2022

Thank you so much for implementing this alert! 🌟
Could you check if the Hash is really used somewhere? It is maybe implemented in the client but not in the server?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants