This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
upload RELEASE wheel to pypi.org #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
passing the workflow category and wheel file name to nm-upload-assets-to-gcp.yml workflow so that they can be used by the publish_whl action.
derekk-nm
requested review from
dbarbuzzi,
dhuangnm,
andy-neuma and
robertgshaw2-neuralmagic
|
@andy-neuma , I'm not sure that the name of the wheel as passed to |
dhuangnm
suggested changes
Jul 9, 2024
andy-neuma
approved these changes
Jul 9, 2024
- refactor code from nm-cp-assets that gets wheel and tar.gz files into a new action that can be used for that and our nm-upload-assets-to-gcp.yml workflow - correct syntax in the if statement - use nm-actions @v1.0.0
dhuangnm
reviewed
Jul 9, 2024
dhuangnm
approved these changes
Jul 9, 2024
SUMMARY: * updated "build test" to accept an array of benchmarking labels * updated "remote push" and "nightly" workflows to include benchmarking on h100's * adjusted docker job to have same criteria as upload job. did this since upload could fail, but for auth reasons and this shouldn't stop us from push docker. TEST PLAN: runs on remote push --------- Co-authored-by: andy-neuma <[email protected]>
- refactor code from nm-cp-assets that gets wheel and tar.gz files into a new action that can be used for that and our nm-upload-assets-to-gcp.yml workflow - correct syntax in the if statement - use nm-actions @v1.0.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides uploading all generated assets to our NeuralMagic pypi server, we also want to push generated wheels to the external pypi.org server for RELEASE versions only.
The structure of the workflows doesn't allow pre-testing of these changes, since they should only apply when wf_category is "RELEASE". Discussing w/ @andy-neuma , we'll just have to see if it fails/succeeds when we're ready to release.