Fix step-status script (#333)

This PR fixes the `step-status` script, so the comparison cannot be broken if the variable is unset/empty, preventing the error below: ![Screenshot 2024-06-25 100134-fs8](https://github.com/neuralmagic/nm-vllm/assets/642904/725ab2d9-d589-47c7-b8e8-30d8463528f0) It also removes some unused variable definitions that were responsible for this particular instance of the error.
neuralmagic · Jun 27, 2024 · 80701e4 · 80701e4
1 parent d4e2059
commit 80701e4
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/.github/actions/nm-summary-build/action.yml b/.github/actions/nm-summary-build/action.yml
@@ -20,8 +20,6 @@ runs:
   using: composite
   steps:
   - run: |
-      BUILD_STATUS=${{ inputs.build_status }}
-      BUILD_EMOJI=$(./.github/scripts/step-status ${BUILD_STATUS})
       WHL_STATUS=${{ inputs.whl_status }}
       WHL_EMOJI=$(./.github/scripts/step-status ${WHL_STATUS})
       echo "testmo URL: ${{ inputs.testmo_run_url }}" >> $GITHUB_STEP_SUMMARY

diff --git a/.github/scripts/step-status b/.github/scripts/step-status
@@ -5,7 +5,7 @@
 
 STEP_STATUS=${1}
 
-if [ $STEP_STATUS -eq 0 ]; then
+if [ "$STEP_STATUS" -eq 0 ]; then
     # green check
     echo -e "\xE2\x9C\x85"
 else