-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use explainaboard.serialization.legacy in SDK 0.11.2 #334
Conversation
Thanks! Not sure if @OscarWang114 has started this, but I think we can maybe create a PR that bumps the SDK version and fixes all the breaking changes like this one? |
Also, here are:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks good to me.
Thanks for the checklist. I find another error when submitting the system in this issue #336. This error doesn't relate to the import error in this PR. I'll go ahead to merge this one first. |
@qjiang002 Just to clarify, are we running on 0.11.2 already? I think this repo is still using 0.11.1. If we merge this now, it would break our staging and production environment. |
Thanks @lyuyangh for the reminder. The current requirements still uses 0.11.1. I will not merge this PR now and will put this change in another PR for fixing the bumping version issues together. |
Thanks @qjiang002 and @lyuyangh ! I haven't started, and yes feel free to submit another PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the future we should convert to the new serialization code, but I think this works for now.
@qjiang002 : does the "invalid" tag mean that this will never be merged? If so I think you can close the PR. |
After updating SDK to version 0.11.2, the web cannot run locally due to import error
In the new SDK, the
general_to_dict
function is inexplainaboard.serialization.legacy
.Fix import error by using
from explainaboard.serialization.legacy import general_to_dict