-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI Design Suggestion of ExplainaBoard Client #38
Comments
Thanks @pfliu-nlp! I think that all the comments here are valid. I think we should definitely remove Regarding the other design decisions, I think it's reasonably easy to separate the discussion of which functions should be provided (the focus of the current PRs) and how they should be provided (the focus of your discussion here). So as a way to move forward I'd suggest that we review/merge the current PRs, and then after that decide about the design decisions in this issue. Does that sound reasonable? |
Sounds good! |
Current Implementation (in the latest PRs)
Unfriendly Points
explainaboard_client.client
: too long and verbose and no one wants to remember thisfrom explainaboard_client.config import Config
: the additional burden to remember this (importing Config)email
or even remove the config!Some potential better designs in my mind (from worse -> better)
1.
2.
3.
3.14
The text was updated successfully, but these errors were encountered: