Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign API to be simpler #31

Closed
4 tasks
neubig opened this issue Oct 10, 2022 · 1 comment
Closed
4 tasks

Redesign API to be simpler #31

neubig opened this issue Oct 10, 2022 · 1 comment

Comments

@neubig
Copy link
Collaborator

neubig commented Oct 10, 2022

Right now the API is complicated, requiring creation of undocumented data members and use of two libraries explainaboard_client and explainaboard_api_client. We should redesign this to be simpler. Here are some functions to be implemented.

  • evaluate_system_file(): Perform evaluation from system output files (@neubig is working on this now)
  • evaluate_system(): Perform evaluation from data that is stored in memory
  • find_systems(): Find systems
  • delete_system(): Delete a system by ID
@pfliu-nlp
Copy link
Collaborator

pfliu-nlp commented Oct 10, 2022

Hi, @neubig thanks for these PRs, which are great and I think reflected many things we discussed last meeting.

I carefully read these PRs, instead of commenting on them one by one, I made a holistic suggestion here: #38 (since the final goal is all about the users, so maybe having a nice overall picture w.r.t the UI is good.

@neubig neubig closed this as completed Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants