Fix Processor._customize_analyses #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like there is a type-related error on Python 3.8, but I can take a look after that. |
|
@neubig It was resolved. |
lyuyangh
reviewed
Oct 24, 2022
lyuyangh
approved these changes
Oct 24, 2022
neubig
approved these changes
Oct 24, 2022
pfliu-nlp
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR restores the previous behavior in
Processor._customize_analyses.Details
Processor._customize_analyseswas changed resently to "add" given metrics to default metrics, but the original behavior was "replace" it with the given metrics. This change restores the original behavior.This change also introduces
MetricConfig.replace_languagesandAnalysisLevel.replace_metric_configsfunctions, which creates a new object by copying self with replacing several members.References
Blocked by