fix: don't use peer deps - use regular deps #736
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for netlify-plugin-gatsby-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for netlify-plugin-gatsby-demo-v5 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pieh
commented
Dec 19, 2023
Comment on lines
-19
to
-23
| /** | ||
| * Depending on the version of '@gatsbyjs/reach-router' installed, the 'match' method may not be defined. | ||
| * This check ensures that this continues to work as expected between v1 and v2 of the package. | ||
| */ | ||
| const reachMatch = reachRouterMatch || reachRouterMatchPath |
There was a problem hiding this comment.
the behavior of match (v2 of router) / matchPath (v1 of router) did not change - with move to actual dependency we don't need to pick one or the other and can straight import match as reachMatch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This removes peer deps usage of build plugin - those cause problems in autoinstallation scenarios with package managers that enforce strict dependencies / no hoisting scenarios (for example by default with pnpm)
Test plan
Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal
https://linear.app/netlify/issue/COM-225/netlify-dev-fails-on-monorepo-setup#comment-a8eee1ec
Standard checks:
🧪 Once merged, make sure to update the version if needed and that it was
published correctly.