Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified loadGatsbyConfig to support TS #646

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

graydonpleasants
Copy link

Summary

Modified the plugin to also look for a gatsby-config.ts file, something now supported by Gatsby.

Test plan

  1. Visit the Deploy Preview (insert link to specific page) ...

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

Issue I Created

Standard checks:

  • Check the Deploy Preview's Demo site for your PR's functionality
  • Add docs when necessary

🧪 Once merged, make sure to update the version if needed and that it was
published correctly.

@graydonpleasants graydonpleasants requested a review from a team as a code owner July 5, 2023 18:32
@netlify
Copy link

netlify bot commented Jul 5, 2023

Deploy Preview for netlify-plugin-gatsby-demo-v5 ready!

Name Link
🔨 Latest commit d630b4d
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-gatsby-demo-v5/deploys/64a5b8b8694fce0008eb651d
😎 Deploy Preview https://deploy-preview-646--netlify-plugin-gatsby-demo-v5.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 5, 2023

Deploy Preview for netlify-plugin-gatsby-demo ready!

Name Link
🔨 Latest commit d630b4d
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-gatsby-demo/deploys/64a5b8b840692d0008b85fd8
😎 Deploy Preview https://deploy-preview-646--netlify-plugin-gatsby-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pieh
Copy link
Contributor

pieh commented Jul 11, 2023

Does this actually work? From reading this it would try to require() a typescript file which wouldn't work in default Node.js environment unless some kind of "transpile TS on the fly hack" was used (for example ts-node/register)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants