Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update getSecrets types #331

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: update getSecrets types #331

wants to merge 1 commit into from

Conversation

dwwoelfel
Copy link
Contributor

Which problem is this pull request solving?

Contentful and sanity are missing in autocomplete in the return value of getSecrets

Describe the solution you've chosen

Adds sanity and contentful to the type on NetlifySecrets

Also gets the fieldName from the graphql query so that we don't have to normalize the field names or camelCase them ourselves.

Checklist

Please add a x inside each checkbox:

  • I have read the contribution guidelines.
  • The status checks are successful (continuous integration). Those can be seen below.

@github-actions github-actions bot added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant