Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sites-create-template): auto-link cloned repo to the created net… #6914

Merged
merged 4 commits into from
Nov 20, 2024

Conversation

benhancock
Copy link
Contributor

…lify site

🎉 Thanks for submitting a pull request! 🎉

Summary

Fixes #4438

This PR adds functionality (requested in #4438) to sites:create-template wherein after cloning the newly created repo, the cli will prompt the user asking if they'd like to link the directory to the cloned repo.

This is what the user saw before our changes:
Screenshot 2024-11-04 at 9 03 52 AM

This is the dialog the user sees with our changes:
Screenshot 2024-11-04 at 9 03 26 AM

This PR also contains tests for the new functionality and error handling, including in the case of a site already being linked to a parent directory.


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@benhancock benhancock requested a review from a team as a code owner November 4, 2024 14:06
@DanielSLew DanielSLew enabled auto-merge (squash) November 19, 2024 17:00
@sarahetter sarahetter added the automerge Add to Kodiak auto merge queue label Nov 20, 2024
@DanielSLew DanielSLew merged commit 89be8a6 into netlify:main Nov 20, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Add to Kodiak auto merge queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(sites-create-template): auto-link cloned repo to the created netlify site
3 participants