Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inject env from envelope for ntl deploy --build #6225

Closed
wants to merge 6 commits into from
Closed

Conversation

Skn0tt
Copy link
Contributor

@Skn0tt Skn0tt commented Nov 29, 2023

Addresses https://linear.app/netlify/issue/COM-207/inject-env-vars-from-envelope-on-ntl-deploy-build.

We were fetching env vars from Envelope for ntl build, but not for ntl deploy --build. This PR also adds the env var injection logic to ntl deploy --build.

@Skn0tt Skn0tt requested a review from a team as a code owner November 29, 2023 09:30
@Skn0tt Skn0tt self-assigned this Nov 29, 2023
Copy link

📊 Benchmark results

Comparing with 55ff33e

  • Dependency count: 1,398 (no change)
  • Package size: 404 MB (no change)
  • Number of ts-expect-error directives: 0 (no change)

@Skn0tt
Copy link
Contributor Author

Skn0tt commented Nov 29, 2023

ha, I should've tested this out locally before working on the PR. it looks like it was indeed already working before? will investigate, turning this to draft

@Skn0tt Skn0tt marked this pull request as draft November 29, 2023 09:43
@Skn0tt
Copy link
Contributor Author

Skn0tt commented Nov 29, 2023

oh, we're doing that here, @netlify/config is dealing with this for us!

const cachedConfig = await actionCommand.getConfig({
cwd: flags.cwd ? this.workingDir : this.jsWorkspaceRoot || this.workingDir,
repositoryRoot: rootDir,
packagePath: this.workspacePackage,
// The config flag needs to be resolved from the actual process working directory
configFilePath: packageConfig,
state,
token,
...apiUrlOpts,
})

forget about this PR, then :D

@Skn0tt Skn0tt closed this Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant