-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add blobs upload step #6223
Conversation
📊 Benchmark resultsComparing with a5a5263
|
9602962
to
94b165c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe you want to refactor it but IMHO the deployProgressCb
should get the options or the base command as argument and then decide if it should log based on the json or silent flags. as this logic is already done multiple times here in the deploy.ts file.
Co-authored-by: Eduardo Bouças <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary
Bringing netlify/build#5404 to the CLI. This adds a step before deployment where we upload blobs to the deploy store.
In addition, running
netlify build
will clean up any lingering blobs from a previous build.Close https://linear.app/netlify/issue/FRA-103
Close https://linear.app/netlify/issue/ADN-88
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)