Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add blobs upload step #6223

Merged
merged 6 commits into from
Dec 4, 2023
Merged

feat: add blobs upload step #6223

merged 6 commits into from
Dec 4, 2023

Conversation

kitop
Copy link
Contributor

@kitop kitop commented Nov 28, 2023

Summary

Bringing netlify/build#5404 to the CLI. This adds a step before deployment where we upload blobs to the deploy store.
In addition, running netlify build will clean up any lingering blobs from a previous build.

Close https://linear.app/netlify/issue/FRA-103
Close https://linear.app/netlify/issue/ADN-88


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

Copy link

github-actions bot commented Nov 28, 2023

📊 Benchmark results

Comparing with a5a5263

  • Dependency count: 1,399 (no change)
  • Package size: 405 MB (no change)
  • Number of ts-expect-error directives: 0 (no change)

@kitop kitop force-pushed the kitop/blob-upload branch from 9602962 to 94b165c Compare November 28, 2023 20:29
@kitop kitop marked this pull request as ready for review November 28, 2023 20:32
@kitop kitop requested a review from a team as a code owner November 28, 2023 20:32
src/commands/deploy/deploy.ts Outdated Show resolved Hide resolved
src/commands/deploy/deploy.ts Outdated Show resolved Hide resolved
src/commands/deploy/deploy.ts Outdated Show resolved Hide resolved
tests/integration/commands/deploy/deploy.test.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@lukasholzer lukasholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you want to refactor it but IMHO the deployProgressCb should get the options or the base command as argument and then decide if it should log based on the json or silent flags. as this logic is already done multiple times here in the deploy.ts file.

Co-authored-by: Eduardo Bouças <[email protected]>
@kitop kitop requested a review from eduardoboucas December 1, 2023 13:57
Copy link
Collaborator

@lukasholzer lukasholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kitop kitop enabled auto-merge (squash) December 4, 2023 14:08
@kitop kitop merged commit 33177fc into main Dec 4, 2023
35 checks passed
@kitop kitop deleted the kitop/blob-upload branch December 4, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants