Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ntl serve for v2 functions, follow-ups #6210

Merged
merged 3 commits into from
Nov 28, 2023
Merged

fix: ntl serve for v2 functions, follow-ups #6210

merged 3 commits into from
Nov 28, 2023

Conversation

Skn0tt
Copy link
Contributor

@Skn0tt Skn0tt commented Nov 27, 2023

Contains two follow-ups to #6076, that were discovered while working on the Astro adapter.

  1. ntl serve should pick up routes from manifest.json
  2. __netlify-entrypoint.js is the wrong extension, it needs to be .mjs - see https://github.com/netlify/zip-it-and-ship-it/blame/f5fb309109408d25544fe34bdee77f917ff679e7/src/runtimes/node/utils/entry_file.ts#L150

@Skn0tt Skn0tt requested a review from a team as a code owner November 27, 2023 13:35
@Skn0tt Skn0tt requested a review from eduardoboucas November 27, 2023 13:35
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2023 •
edited
Loading

📊 Benchmark results

Comparing with 4027528

  • Dependency count: 1,396 (no change)
  • Package size: 404 MB (no change)
  • Number of ts-expect-error directives: 0 (no change)

@Skn0tt Skn0tt mentioned this pull request Nov 27, 2023
Closed
@Skn0tt Skn0tt enabled auto-merge (squash) November 28, 2023 06:47
@Skn0tt Skn0tt disabled auto-merge November 28, 2023 06:57
@Skn0tt Skn0tt merged commit af800af into main Nov 28, 2023
33 checks passed
@Skn0tt Skn0tt deleted the serve-v2 branch November 28, 2023 07:12
@token-generator-app token-generator-app bot mentioned this pull request Nov 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eduardoboucas eduardoboucas eduardoboucas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Skn0tt @eduardoboucas