chore: replace ava with vitest #6103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Benchmark resultsComparing with 00e8d9d
|
sarahetter
reviewed
Oct 30, 2023
Even though we're not using ava in this package, our internal lint package (@netlify/eslint-config-node) doesn't recognize this. As a result it's incorrectly failing lint checks because files that are not test files as being imported into actual test files (the specific rule that's failing is `ava/no-import-test-files`.
… of ssh://github.com/netlify/cli into ericapisani/ct-89-finish-conversion-from-ava-to-vitest
khendrikse
previously approved these changes
Oct 31, 2023
ericapisani
changed the title
ericapisani
changed the title
update vitest command
… of ssh://github.com/netlify/cli into ericapisani/ct-89-finish-conversion-from-ava-to-vitest
we need to come back and fix these
sarahetter
approved these changes
Oct 31, 2023
ericapisani
added
automerge
kodiakhq
bot
deleted the
ericapisani/ct-89-finish-conversion-from-ava-to-vitest
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes this issue
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)