fix: fix function URL matching #6052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Benchmark resultsComparing with 8ae2d5b
|
jenae-janzen
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In recent changes to how we match URL paths for functions, we started relying solely on
FunctionsRegistry.getFunctionForURLPath, even for matching paths for the default functions URL (i.e./.netlify/functions).The problem is that this method is returning
undefinedif there is no matching function, but we also need to know when a URL is definitely for a function (i.e. starts with/.netlify/functions) regardless of whether an actual function for that name exists.This is important so that we handle 404s in the functions server, letting us return the right status code and message. This PR fixes that.