Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: tests/integration/210.command.deploy.test.cjs #5927

Conversation

hereje
Copy link
Contributor

@hereje hereje commented Aug 6, 2023

🎉 Thanks for submitting a pull request! 🎉

Summary

  • refactor: move and rename file
  • refactor: convert file to esm
  • refactor: replace ava with vitest
  • refactor: replace got with node-fetch
  • style: apply lint rules

Related to: #5698


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • [] Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

hereje added 5 commits August 5, 2023 17:21
- convert file from cjs to esm
- adjust file accordingly
- replace ava with vitest
- adjust tests accordingly
- run tests concurrently
- chore: set hook timeout as 60_000
@hereje hereje requested a review from a team as a code owner August 6, 2023 01:05
@github-actions
Copy link

github-actions bot commented Aug 6, 2023

📊 Benchmark results

Comparing with a84d2ff

  • Dependency count: 1,668 (no change)
  • Package size: 497 MB ⬇️ 0.00% decrease vs. a84d2ff

lukasholzer
lukasholzer previously approved these changes Aug 11, 2023
@lukasholzer lukasholzer enabled auto-merge (squash) August 11, 2023 07:55
@lukasholzer lukasholzer self-requested a review August 16, 2023 07:23
@lukasholzer lukasholzer dismissed their stale review August 16, 2023 07:23

files got updated

@sarahetter sarahetter requested a review from a team as a code owner September 6, 2023 15:59
@sarahetter
Copy link
Contributor

Lint error in test

- convert file from cjs to esm
- adjust file accordingly
- replace ava with vitest
- adjust tests accordingly
- run tests concurrently
- chore: set hook timeout as 60_000
…test.cjs' of https://github.com/hereje/cli into refactor_test_esm/tests/integration/210.command.deploy.test.cjs
auto-merge was automatically disabled September 26, 2023 21:36

Head branch was pushed to by a user without write access

@sarahetter
Copy link
Contributor

Another weird diff

@sarahetter sarahetter added the automerge Add to Kodiak auto merge queue label Oct 24, 2023
@kodiakhq kodiakhq bot merged commit 1e78527 into netlify:main Oct 24, 2023
60 checks passed
@hereje hereje deleted the refactor_test_esm/tests/integration/210.command.deploy.test.cjs branch October 24, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Add to Kodiak auto merge queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants