Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: tests/integration/500.command.dev.test.cjs #5924

Merged
merged 8 commits into from
Sep 6, 2023
Merged

refactor: tests/integration/500.command.dev.test.cjs #5924

merged 8 commits into from
Sep 6, 2023

Conversation

hereje
Copy link
Contributor

@hereje hereje commented Aug 4, 2023

🎉 Thanks for submitting a pull request! 🎉

Summary

  • refactor: move and rename file
  • refactor: convert test file to esm
  • refactor: replace ava with vitest
  • refactor: replace got with node-fetch

Related to: #5698

For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

hereje added 4 commits August 3, 2023 16:02
@hereje
refactor: move and rename file
3372448
@hereje
refactor: convert test file to esm
209471f 
- convert file to esm
- adjust file accordingly
@hereje
refactor: replace ava with vitest
62c57ef 
- replace ava with vitest
- adjust tests accordingly
- run test concurrently
@hereje
refactor: replace got with node-fetch
29f0458
@hereje hereje requested a review from a team as a code owner August 4, 2023 18:18
@hereje hereje mentioned this pull request Aug 4, 2023
Closed
@github-actions
Copy link

github-actions bot commented Aug 4, 2023 •
edited
Loading

📊 Benchmark results

Comparing with 5bb9766

  • Dependency count: 1,319 (no change)
  • Package size: 280 MB (no change)

@sarahetter sarahetter added the automerge Add to Kodiak auto merge queue label Sep 6, 2023
@kodiakhq kodiakhq bot requested a review from a team as a code owner September 6, 2023 16:41
@kodiakhq kodiakhq bot merged commit 3876c5b into netlify:main Sep 6, 2023
@hereje hereje deleted the refactor_test_esm/tests/integration/500.command.dev.test.cjs branch September 6, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahetter sarahetter sarahetter approved these changes

Assignees
No one assigned
Labels
automerge Add to Kodiak auto merge queue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hereje @sarahetter