Skip to content

Commit

Permalink
fix!: execute user and integrations edge functions in the correct ord…
Browse files Browse the repository at this point in the history
…er (#5624)

* fix: correctly execute user and integrations edge functions in the right order

* chore: fix types

* chore: add test for order of edge-functions

* chore: enable featureflag
  • Loading branch information
danez authored Apr 17, 2023
1 parent 9066166 commit 0535230
Show file tree
Hide file tree
Showing 24 changed files with 385 additions and 182 deletions.
2 changes: 2 additions & 0 deletions .eslintrc.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ module.exports = {
extends: '@netlify/eslint-config-node',
plugins: ['sort-destructure-keys'],
parserOptions: {
ecmaVersion: '2020',
babelOptions: {
parserOpts: {
sourceType: 'unambiguous',
Expand Down Expand Up @@ -80,6 +81,7 @@ module.exports = {
{
files: ['src/**/*.mjs', 'bin/**/*.mjs'],
parserOptions: {
ecmaVersion: '2020',
sourceType: 'module',
babelOptions: {
parserOpts: {
Expand Down
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ vendor
.DS_STORE

# Local Netlify folder
.netlify
/.netlify

# site
test-site
Expand Down
2 changes: 1 addition & 1 deletion site/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 6 additions & 3 deletions src/lib/edge-functions/proxy.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -79,11 +79,12 @@ export const initializeProxy = async ({
const server = prepareServer({
config,
configPath,
directories: [internalFunctionsPath, userFunctionsPath].filter(Boolean),
directory: userFunctionsPath,
env: configEnv,
getUpdatedConfig,
importMaps: [importMap].filter(Boolean),
inspectSettings,
internalDirectory: internalFunctionsPath,
internalFunctions,
port: isolatePort,
projectDir,
Expand Down Expand Up @@ -153,11 +154,12 @@ export const isEdgeFunctionsRequest = (req) => req[headersSymbol] !== undefined
const prepareServer = async ({
config,
configPath,
directories,
directory,
env: configEnv,
getUpdatedConfig,
importMaps,
inspectSettings,
internalDirectory,
internalFunctions,
port,
projectDir,
Expand Down Expand Up @@ -187,9 +189,10 @@ const prepareServer = async ({
bundler,
config,
configPath,
directories,
directories: [directory].filter(Boolean),
env: configEnv,
getUpdatedConfig,
internalDirectories: [internalDirectory].filter(Boolean),
internalFunctions,
projectDir,
runIsolate,
Expand Down
Loading

1 comment on commit 0535230

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📊 Benchmark results

  • Package size: 302 MB

Please sign in to comment.