test: rewrite test to work around Windows bug #5945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're not quite sure what's going on but the async import with `?one` fails on Windows with node 22.12.0.
serhalp
force-pushed
the
test/fix-windows-test
branch
from
12bae4b to
a17742c
Compare
pieh
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This test started failing on Windows in the last day (example). We're not quite sure what's going on but the async import with
?onefails.We think it's because of the bump to node 22.12.0 (we automatically pull in the latest node version in CI). The most recent successful runs were using 22.11.0. 🤷🏼