feat: capture plugin errors during ready phase
#5681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request adds or modifies JavaScript ( |
Skn0tt
reviewed
May 29, 2024
| eventName: string, | ||
| featureFlags: FeatureFlags, | ||
| ) => { | ||
| if (!featureFlags.netlify_build_plugin_system_log) { |
There was a problem hiding this comment.
I failed to mention this on the last PR, but I think this flag should be called netlify_build_plugin_system_log_errors or similar. The current name makes it sound like it's related to #5391. Having said that, the flag is super short-lived, so it shouldn't matter too much.
There was a problem hiding this comment.
Yeah, I totally see that. Let's hope we can kill the flag soon.
Skn0tt
reviewed
May 29, 2024
| return { childProcess } | ||
| } catch (error) { | ||
| if (featureFlags.netlify_build_plugin_system_log) { | ||
| // Wait for stderr to be flushed. | ||
| await pSetTimeout(0) |
There was a problem hiding this comment.
would setImmediate also work here?
There was a problem hiding this comment.
It would, yes. Just trying to stay as conservative as possible with this change.
Skn0tt
approved these changes
May 29, 2024
Merged
Merged
This was referenced Jun 5, 2024
Merged
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #5679. Extracts the logic for registering and unregistering the listeners into a separate method, which is now called for both the
loadand thereadyphases of the plugin initialisation.Sadly I cannot write a test that asserts the behaviour for the
readyphase because I can't find a way to produce that locally. Since we use the same method asload, our existing tests gives us some coverage.