Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fetch integrations only when online #5380

Merged
merged 4 commits into from
Nov 13, 2023

Conversation

khendrikse
Copy link
Contributor

@khendrikse khendrikse commented Nov 10, 2023

🎉 Thanks for submitting a pull request! 🎉

Summary

Right now we always fetch integrations, even when the offline option is being used.

const mergedIntegrations = await mergeIntegrations({

This was mentioned by @eduardoboucas in this thread:
https://netlify.slack.com/archives/C043UGRAC3F/p1699613379190979

Let's make sure we don't do that when the offline boolean is true.

Fixes https://linear.app/netlify/issue/CT-272/bug-only-fetch-integrations-if-offline-is-false-in-netlify-build


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures
    your code follows our style guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@khendrikse khendrikse requested review from a team as code owners November 10, 2023 14:51
@khendrikse khendrikse self-assigned this Nov 10, 2023
Copy link
Member

@eduardoboucas eduardoboucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It would be cool to cover this with a test.

@khendrikse khendrikse merged commit 916a54c into main Nov 13, 2023
36 checks passed
@khendrikse khendrikse deleted the ct-272/fetch-integrations-only-when-online branch November 13, 2023 12:23
This was referenced May 23, 2024
This was referenced Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants