Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update edge-bundler and provide user-facing logger #5317

Merged
merged 1 commit into from
Oct 9, 2023
Merged

fix: update edge-bundler and provide user-facing logger #5317

merged 1 commit into from
Oct 9, 2023

Conversation

Skn0tt
Copy link
Contributor

@Skn0tt Skn0tt commented Oct 9, 2023

Providing the user-facing logger will fix behaviour where we're --json is passed to netlify build and we're destroying the JSON by console.log-ing from within edge-bundler.

@Skn0tt Skn0tt requested review from a team as code owners October 9, 2023 14:42
@Skn0tt Skn0tt self-assigned this Oct 9, 2023
@Skn0tt Skn0tt enabled auto-merge (squash) October 9, 2023 15:00
@Skn0tt Skn0tt mentioned this pull request Oct 9, 2023
Closed
1 task
@Skn0tt Skn0tt merged commit e1f2a36 into main Oct 9, 2023
35 checks passed
@Skn0tt Skn0tt deleted the edge-bundler-user-logger branch October 9, 2023 15:16
@netlify-circleci netlify-circleci mentioned this pull request Oct 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasholzer lukasholzer lukasholzer approved these changes

Assignees

@Skn0tt Skn0tt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Skn0tt @lukasholzer