Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: detect bun as package manager #5306

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Conversation

kitop
Copy link
Contributor

@kitop kitop commented Sep 29, 2023

🎉 Thanks for submitting a pull request! 🎉

Summary

As part of https://github.com/netlify/buildbot/issues/2912 and https://github.com/netlify/buildbot/issues/2914

Add detection of bun as a package manager. For that, we depend on a bun.lockb as documented in https://bun.sh/docs/install/lockfile.


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures
    your code follows our style guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@kitop kitop requested review from a team as code owners September 29, 2023 15:56
Copy link
Contributor

@JGAntunes JGAntunes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small notes, looking good overall 🚀

4xposed
4xposed previously approved these changes Oct 2, 2023
Copy link
Contributor

@4xposed 4xposed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kitop kitop force-pushed the kitop/detect-bun-package-manager branch from 2cde21b to 082a174 Compare October 2, 2023 15:32
@JGAntunes JGAntunes self-assigned this Oct 9, 2023
@kodiakhq kodiakhq bot merged commit 5d91c31 into main Oct 9, 2023
35 checks passed
@kodiakhq kodiakhq bot deleted the kitop/detect-bun-package-manager branch October 9, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants