Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: detect bun as runtime #5300

Merged
merged 4 commits into from
Oct 2, 2023
Merged

feat: detect bun as runtime #5300

merged 4 commits into from
Oct 2, 2023

Conversation

lukasholzer
Copy link
Contributor

@lukasholzer lukasholzer commented Sep 19, 2023

🎉 Thanks for submitting a pull request! 🎉

Summary

Fixes Parts of https://github.com/netlify/buildbot/issues/2914

Adding bun here as a runtime to improve our heuristics and detection mechanism to see who is already using bun on our platform.

This is to add visibility that we can perform humio queries on the runtime field and see if someone is already using bun.

As you can already use it by manually installing it. (Bypassing the npm install with adding a NPM_FLAGS=--version and doing the install in the build command – this was the previous workaround to get pnpm support before we had it.)


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures
    your code follows our style guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@lukasholzer lukasholzer requested review from JGAntunes and a team September 19, 2023 16:19
@lukasholzer lukasholzer self-assigned this Sep 19, 2023
@lukasholzer lukasholzer requested a review from a team as a code owner September 19, 2023 16:19
@4xposed
Copy link
Contributor

4xposed commented Sep 19, 2023

I don't think this really addresses what's intended by https://github.com/netlify/buildbot/issues/2912 though

@lukasholzer lukasholzer requested a review from 4xposed September 20, 2023 10:33
@lukasholzer lukasholzer requested a review from kitop October 2, 2023 08:53
@lukasholzer lukasholzer merged commit 6f87850 into main Oct 2, 2023
30 checks passed
@lukasholzer lukasholzer deleted the feat/detect-bun-as-runtime branch October 2, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants