Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes an issue where the type imports could not be resolved #5297

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

lukasholzer
Copy link
Contributor

🎉 Thanks for submitting a pull request! 🎉

Summary

Fixes an issue where the types could not be resolved in the next-runtime


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures
    your code follows our style guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@lukasholzer lukasholzer requested review from a team as code owners September 19, 2023 12:37
Copy link
Member

@eduardoboucas eduardoboucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For posterity sake, could you add some context to why importing from .js instead of .d.ts fixes the issue?

@lukasholzer
Copy link
Contributor Author

For posterity sake, could you add some context to why importing from .js instead of .d.ts fixes the issue?

I have no idea. IMHO, it should work with .d.ts as well, but this was a good try-and-error thing by modifying the node_modules and seeing the types getting picked up. Had not had the time to investigate deeper.

@lukasholzer lukasholzer merged commit 0a72c89 into main Sep 19, 2023
30 checks passed
@lukasholzer lukasholzer deleted the fix/fix-type-imports branch September 19, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants