Skip to content

Commit

Permalink
ci: remove the --no-package-lock tests
Browse files Browse the repository at this point in the history
These exist to test against fully updated dependencies and transitive dependencies, but
this means that builds are not reproducible and even main can suddenly start failing
without any code changes. Plus, Renovate is already our blessed, more controlled solution
for this.
  • Loading branch information
serhalp committed Dec 11, 2024
1 parent c22be64 commit ec44e76
Showing 1 changed file with 0 additions and 23 deletions.
23 changes: 0 additions & 23 deletions .github/workflows/workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -148,29 +148,6 @@ jobs:
node-version: '14.16.0'
install-command: npm ci
machine: '4'
# The buildbot pins Netlify Build's dependencies, like `npm ci`.
# But other consumers do not, like `npm install`.
# So we test both.
- os: ubuntu-latest
node-version: '*'
install-command: npm install --no-package-lock
machine: '0'
- os: ubuntu-latest
node-version: '*'
install-command: npm install --no-package-lock
machine: '1'
- os: ubuntu-latest
node-version: '*'
install-command: npm install --no-package-lock
machine: '2'
- os: ubuntu-latest
node-version: '*'
install-command: npm install --no-package-lock
machine: '3'
- os: ubuntu-latest
node-version: '*'
install-command: npm install --no-package-lock
machine: '4'
fail-fast: false
steps:
# Sets an output parameter if this is a release PR
Expand Down

0 comments on commit ec44e76

Please sign in to comment.