Skip to content

Commit

Permalink
ci: pin node.js major versions
Browse files Browse the repository at this point in the history
and let Renovate manage updates
  • Loading branch information
serhalp committed Dec 11, 2024
1 parent 18cf92a commit 5c3f170
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 10 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/benchmark.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- name: Setup Node.js environment
uses: actions/setup-node@v4
with:
node-version: '*'
node-version: '22'
cache: 'npm'
check-latest: true

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pre-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
fetch-depth: 0
- uses: actions/setup-node@v4
with:
node-version: '*'
node-version: '22'
check-latest: true
registry-url: 'https://registry.npmjs.org'
- name: Extract tag, version and package
Expand Down
17 changes: 9 additions & 8 deletions .github/workflows/workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
if: ${{ !steps.release-check.outputs.IS_RELEASE }}
- uses: actions/setup-node@v4
with:
node-version: 18
node-version: 22
if: ${{ !steps.release-check.outputs.IS_RELEASE }}
- name: Install dependencies
run: npm ci
Expand All @@ -50,11 +50,12 @@ jobs:
strategy:
matrix:
os: [ubuntu-24.04, macos-14, windows-2022]
node-version: ['*']
node-version: ['22']
# Must include the minimum deno version from the `DENO_VERSION_RANGE` constant in `node/bridge.ts`.
deno-version: ['v1.37.0', 'v1.44.4']
include:
- os: ubuntu-24.04
# Earliest supported version
node-version: '14.16.0'
deno-version: 'v1.44.4'
fail-fast: false
Expand Down Expand Up @@ -122,7 +123,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-24.04, macos-14, windows-2022]
node-version: ['*']
node-version: ['22']
install-command: ['npm ci']
machine: ['0', '1', '2', '3', '4']
include:
Expand Down Expand Up @@ -152,23 +153,23 @@ jobs:
# But other consumers do not, like `npm install`.
# So we test both.
- os: ubuntu-24.04
node-version: '*'
node-version: '22'
install-command: npm install --no-package-lock
machine: '0'
- os: ubuntu-24.04
node-version: '*'
node-version: '22'
install-command: npm install --no-package-lock
machine: '1'
- os: ubuntu-24.04
node-version: '*'
node-version: '22'
install-command: npm install --no-package-lock
machine: '2'
- os: ubuntu-24.04
node-version: '*'
node-version: '22'
install-command: npm install --no-package-lock
machine: '3'
- os: ubuntu-24.04
node-version: '*'
node-version: '22'
install-command: npm install --no-package-lock
machine: '4'
fail-fast: false
Expand Down

0 comments on commit 5c3f170

Please sign in to comment.