Skip to content

Commit

Permalink
fix: update DENO_VERSION_RANGE (#5929)
Browse files Browse the repository at this point in the history
* Update DENO_VERSION_RANGE

* chore: update lower end of deno version range

* test: match deno ranges in tests to DENO_VERSION_RANGE

* fix: update comment with a link to buildbot
  • Loading branch information
mrstork authored Dec 11, 2024
1 parent d56933d commit 5bb784a
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 8 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,11 @@ jobs:
os: [ubuntu-latest, macOS-latest, windows-latest]
node-version: ['*']
# Must include the minimum deno version from the `DENO_VERSION_RANGE` constant in `node/bridge.ts`.
deno-version: ['v1.37.0', 'v1.44.4']
deno-version: ['v1.39.0', 'v1.46.3']
include:
- os: ubuntu-latest
node-version: '14.16.0'
deno-version: 'v1.44.4'
deno-version: 'v1.46.3'
fail-fast: false
steps:
# Increasing the maximum number of open files. See:
Expand Down Expand Up @@ -192,7 +192,7 @@ jobs:
- name: Setup Deno
uses: denoland/setup-deno@v1
with:
deno-version: v1.44.4
deno-version: v1.46.3
if: ${{ !steps.release-check.outputs.IS_RELEASE }}
- name: Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v4
Expand Down
9 changes: 4 additions & 5 deletions packages/edge-bundler/node/bridge.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,10 @@ import { getBinaryExtension } from './platform.js'

const DENO_VERSION_FILE = 'version.txt'

// When updating DENO_VERSION_RANGE, ensure that the deno version installed in the
// build-image/buildbot does satisfy this range!
// We're pinning the range because of an issue with v1.45.0 of the Deno CLI:
// https://linear.app/netlify/issue/FRP-775/deno-cli-v1450-causing-issues
const DENO_VERSION_RANGE = '1.37.0 - 1.44.4'
// When updating DENO_VERSION_RANGE, ensure that the deno version
// on the netlify/buildbot build image satisfies this range!
// https://github.com/netlify/buildbot/blob/f9c03c9dcb091d6570e9d0778381560d469e78ad/build-image/noble/Dockerfile#L410
const DENO_VERSION_RANGE = '1.39.0 - 1.46.3'

type OnBeforeDownloadHook = () => void | Promise<void>
type OnAfterDownloadHook = (error?: Error) => void | Promise<void>
Expand Down

0 comments on commit 5bb784a

Please sign in to comment.