feat!: add getStore method
#58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for blobs-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
the
type: feature
ascorbic
reviewed
Oct 12, 2023
| } | ||
| ``` | ||
|
|
||
| ### Environment-based configuration |
ascorbic
reviewed
Oct 12, 2023
src/types.ts
Outdated
Comment on lines
3
to
6
| export enum HTTPMethod { | ||
| Delete = 'delete', | ||
| Get = 'get', | ||
| Put = 'put', |
There was a problem hiding this comment.
Can I bikeshed these to be all caps?
There was a problem hiding this comment.
The keys or the values?
lukasholzer
previously approved these changes
Oct 17, 2023
| @@ -13,73 +13,163 @@ You can install `@netlify/blobs` via npm: | |||
| npm install @netlify/blobs | |||
| ``` | |||
|
|
|||
| ### Requirements | |||
|
|
|||
| - Deno 1.30 and above or Node.js 16.0.0 and above | |||
There was a problem hiding this comment.
I think we still have to support node 14? @eduardoboucas
| @@ -74,9 +74,7 @@ | |||
| "esbuild": "^0.19.0", | |||
| "husky": "^8.0.0", | |||
| "node-fetch": "^3.3.1", | |||
| "p-map": "^6.0.0", | |||
src/client.ts
Outdated
Comment on lines
7
to
11
| // The name of the environment variable that holds the context in a Base64, | ||
| // JSON-encoded object. If we ever need to change the encoding or the shape | ||
| // of this object, we should bump the version and create a new variable, so | ||
| // that the client knows how to consume the data and can advise the user to | ||
| // update the client if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the API with a breaking change, making a
getStoremethod the entry point into the library.Before reviewing the actual code, I recommend reviewing the API design itself.
@biilmann your proposed design has been incorporated here.