-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Hugo repo & version; add missing Zola alias #35
base: master
Are you sure you want to change the base?
Conversation
* replace `spf13/hugo` with `goghugoio/hugo` since the repo has moved * update Hugo version from 0.19 to 0.94.2 * add link to `cache/cache.go` which lists all current aliases * add missing alias for `zola`
- gutenberg: keats/gutenberg | ||
- zola: getzola/zola |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well… actually Zola is the new repo for Gutenberg (and keats/gutenberg
redirects to getzola/zola
…) — so the question is whether the older aliases shoud be even kept?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking a look! You make a good point; I think it makes sense to keep guttenberg
alias in cache/cache.go
(to avoid breaking old configs which were created when the project was called guttenberg
and haven't been updated since then), but new projects should use zola
instead, so we can remove it from the README.
Maybe it makes sense to also add a comment to cache/cache.go
to specify the lineage and mark one of them as deprecated so folks don't use it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But given GH keeps the redirects it should still work, specifying old gutenberg
version should fetch the correct tarball from zola
repo eventually without breaking (GH actually keeps the old release artifact filenames intact when moving repos)… well, in theory, as back in the day the tgz/bin naming convention was different from the template used currently — so yea I guess nowadays it really doesn't do anything but get the binary from local cache, not sure if it still works for downloading arbitrary archaic releases remotely…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I actually ended up here trying to sync the versions/aliases with a proposed update to build_images installed software list to streamline the GUTENBERG_
/ZOLA_
info to probably make more prominent that <=0.4 was gutenberg and >=0.5 is zola to make it more obvious…)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mbrukman Actually it's well described in:
binrc/templates/templates.toml
Lines 10 to 16 in c3a403d
gutenberg = [ | |
{ range = ">0.0.5, <0.4.3", tarball = "%s-v%s-x86_64-unknown-linux-gnu.tar.gz", bin = "gutenberg" } | |
] | |
zola = [ | |
{ range = ">=0.5.0", tarball = "%s-v%s-x86_64-unknown-linux-gnu.tar.gz", bin = "zola" } | |
] |
incl. the correct templates so things are probably still working even now, five years later;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So maybe just a hint along the way:
- gutenberg: keats/gutenberg | |
- zola: getzola/zola | |
- zola: getzola/zola (formerly gutenberg: keats/gutenberg) |
would suffice?
Otherwise the rest of the PR is all golden, it's about time to update the outdated refs, good job!
@@ -42,15 +42,16 @@ Binrc supports settings binary version numbers as environment variables. It will | |||
in the environment to configure the right version. | |||
|
|||
``` | |||
HUGO_VERSION=0.19 binrc install spf13/hugo | |||
HUGO_VERSION=0.94.2 binrc install gohugoio/hugo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well… this version is already a year old. Would make sense to make it more current before merging.
Related: (question is… whether there should not be a "latest" option?)
spf13/hugo
withgoghugoio/hugo
since the repo has movedcache/cache.go
which lists all current aliaseszola