Fix initial move of servo motor #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can control initial move of servo motor with initialPulseWidth.
|
This PR add the new method |
|
I know the repo is officially unmaintained, but would it still be possible to merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR would fix the problem which is reported in #14 .
I guess that it makes same initial move as Servo library
and this could also avoid initial movement with
.attach(...,0)which would be new feature.
And it would also close #25 #26 .
This PR changes the initial state of servo.ticks and
I have not tested this PR yet, because I don't have servo motor, sorry.
Thus, it might be better to apply this PR after someone's test report.
I create this PR with reference to https://stackoverflow.com/questions/40892922/.
And I am not good at English, thus, if you know better English words,
please fix variable name and comments.