Merge pull request #13 from netgen-layouts/fix-disabled-products

Don't show products which are disabled
netgen-layouts · Jan 26, 2024 · c92abb3 · c92abb3
2 parents b6627a2 + c1ab34c
commit c92abb3
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/lib/Item/ValueConverter/ProductValueConverter.php b/lib/Item/ValueConverter/ProductValueConverter.php
@@ -39,7 +39,7 @@ public function getName(object $object): string
 
     public function getIsVisible(object $object): bool
     {
-        return true;
+        return $object->isEnabled();
     }
 
     public function getObject(object $object): ProductInterface

diff --git a/tests/lib/Item/Stubs/Product.php b/tests/lib/Item/Stubs/Product.php
@@ -8,15 +8,15 @@
 
 final class Product extends BaseProduct
 {
-    public function __construct(int $id, string $name, ?string $slug = null)
+    public function __construct(int $id, string $name, ?string $slug = null, bool $enabled = true)
     {
         parent::__construct();
 
         $this->id = $id;
 
         $this->currentLocale = 'en';
         $this->setName($name);
-
         $this->setSlug($slug);
+        $this->setEnabled($enabled);
     }
 }
diff --git a/tests/lib/Item/ValueConverter/ProductValueConverterTest.php b/tests/lib/Item/ValueConverter/ProductValueConverterTest.php
@@ -76,6 +76,15 @@ public function testGetIsVisible(): void
         );
     }
 
+    public function testGetIsVisibleReturnsFalse(): void
+    {
+        self::assertFalse(
+            $this->valueConverter->getIsVisible(
+                new ProductStub(42, 'Product name', null, false),
+            ),
+        );
+    }
+
     public function testGetObject(): void
     {
         $product = new ProductStub(42, 'Product name');