Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log full command json when sending command fails #993

Closed

Conversation

FrankBakkerNl
Copy link
Contributor

Proposed change

Log full command json when sending command to HA fails

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link
Collaborator

@helto4real helto4real left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (adf4b3f) 77.81% compared to head (3767dc0) 77.88%.

❗ Current head 3767dc0 differs from pull request most recent head 46eb162. Consider uploading reports for the commit 46eb162 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #993      +/-   ##
==========================================
+ Coverage   77.81%   77.88%   +0.06%     
==========================================
  Files         177      177              
  Lines        3539     3545       +6     
  Branches      444      443       -1     
==========================================
+ Hits         2754     2761       +7     
  Misses        609      609              
+ Partials      176      175       -1     
Flag Coverage Δ
unittests 77.88% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrankBakkerNl FrankBakkerNl enabled auto-merge (squash) November 8, 2023 21:00
auto-merge was automatically disabled November 14, 2023 22:50

Pull request was closed

@FrankBakkerNl FrankBakkerNl force-pushed the Improve_error_failedcommand branch from 46eb162 to 9691a5d Compare November 14, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants